[PATCH] D151932: Add dsymutil dwarf5 tests for darwin

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test:30
+
+; clang -g -c -O1 b.cpp -Xclang -dwarf-version=4 -o 2.o
+
----------------
Just FYI: -gdwarf4 is a driver option with the same effect.


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test:43
+CHECK-NEXT: 0x00000000: Compile Unit: length = 0x0000007d, format = DWARF32, version = 0x0005, unit_type = DW_UT_compile, abbr_offset = 0x0000, addr_size = 0x08 (next unit at 0x00000081)
+CHECK: 0x00000081: Compile Unit: length = 0x00000072, format = DWARF32, version = 0x0004, abbr_offset = 0x0000, addr_size = 0x08 (next unit at 0x000000f7)
+
----------------
It would be good to CHECK for a DW_FORM inside of a DW_AT_location in both CUs to make sure they point to the respective variant of the location list section.


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test:44
+CHECK: 0x00000081: Compile Unit: length = 0x00000072, format = DWARF32, version = 0x0004, abbr_offset = 0x0000, addr_size = 0x08 (next unit at 0x000000f7)
+
+CHECK: .debug_loc contents:
----------------
Same thing for the ranges section.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151932/new/

https://reviews.llvm.org/D151932