[PATCH] D152348: [InstCombine] Transform (icmp eq/ne rotate(X,A0),rotate(X,A1)) -> (icmp eq/ne rotate(X,A0-A1))

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 12:09:40 PDT 2023


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3480
+    // and Amt0/Amt1 are constants.
+    if (IIOp0->getOperand(0) == IIOp1->getOperand(0)) {
+      unsigned OneUses = IIOp0->hasOneUse() + IIOp1->hasOneUse();
----------------
Doesn't this also work if the rotates are on different values? https://alive2.llvm.org/ce/z/rVmJgz


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152348/new/

https://reviews.llvm.org/D152348



More information about the llvm-commits mailing list