[PATCH] D152393: AMDGPU: Remove r600 local id annotations in AMDGPULowerIntrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: AMDGPU, rampitec, Pierre-vh, mareko, nhaehnle.
Herald added subscribers: foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: sstefan1.
Herald added a project: LLVM.

With these dropped and memory intrinsic moved into a generic pass, we
can drop the whole pass.

      

No tests fail with this removed. The new amdgcn intrinsics are
annotated in clang up front.  Theoretically may regress r600, but that
would need new testing and support work (r600 ideally would also
follow the clang handling).

      

If we wanted to refine these values, a better place would be in
AMDGPUAttributor.


https://reviews.llvm.org/D152393

Files:
  llvm/lib/Target/AMDGPU/AMDGPULowerIntrinsics.cpp


Index: llvm/lib/Target/AMDGPU/AMDGPULowerIntrinsics.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/AMDGPULowerIntrinsics.cpp
+++ llvm/lib/Target/AMDGPU/AMDGPULowerIntrinsics.cpp
@@ -154,16 +154,6 @@
       if (expandMemIntrinsicUses(F))
         Changed = true;
       break;
-
-    case Intrinsic::r600_read_tidig_x:
-    case Intrinsic::r600_read_tidig_y:
-    case Intrinsic::r600_read_tidig_z:
-    case Intrinsic::r600_read_local_size_x:
-    case Intrinsic::r600_read_local_size_y:
-    case Intrinsic::r600_read_local_size_z:
-      Changed |= makeLIDRangeMetadata(F);
-      break;
-
     default:
       break;
     }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152393.529386.patch
Type: text/x-patch
Size: 679 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230607/7659bb87/attachment.bin>