[llvm] a4845ea - [InstrProf] Skip Balanced Partitioning tests on ARM

Leandro Lupori via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 11:09:06 PDT 2023


Author: Leandro Lupori
Date: 2023-06-07T17:39:41Z
New Revision: a4845eaf2e9aa18dd900d7cbeff4e5ff52e4b50e

URL: https://github.com/llvm/llvm-project/commit/a4845eaf2e9aa18dd900d7cbeff4e5ff52e4b50e
DIFF: https://github.com/llvm/llvm-project/commit/a4845eaf2e9aa18dd900d7cbeff4e5ff52e4b50e.diff

LOG: [InstrProf] Skip Balanced Partitioning tests on ARM

Balanced Partitioning tests, added by 1794532bb942, currently
hang on ARM, what causes check-all to never finish.

Issue #63168

Differential Revision: https://reviews.llvm.org/D147812

Added: 
    

Modified: 
    llvm/test/tools/llvm-profdata/show-order.proftext
    llvm/unittests/Support/BalancedPartitioningTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-profdata/show-order.proftext b/llvm/test/tools/llvm-profdata/show-order.proftext
index 8ef26847ad77e..1b80677d5d063 100644
--- a/llvm/test/tools/llvm-profdata/show-order.proftext
+++ b/llvm/test/tools/llvm-profdata/show-order.proftext
@@ -1,4 +1,6 @@
 # RUN: llvm-profdata order %s | FileCheck %s
+# PR63168: Balanced Partitioning tests currently hang on ARM.
+# UNSUPPORTED: target=arm{{.*}}
 
 # CHECK: a
 # CHECK: b

diff  --git a/llvm/unittests/Support/BalancedPartitioningTest.cpp b/llvm/unittests/Support/BalancedPartitioningTest.cpp
index ebe518a8e89ca..05f7411b43277 100644
--- a/llvm/unittests/Support/BalancedPartitioningTest.cpp
+++ b/llvm/unittests/Support/BalancedPartitioningTest.cpp
@@ -17,6 +17,13 @@ using testing::Not;
 using testing::UnorderedElementsAre;
 using testing::UnorderedElementsAreArray;
 
+// PR63168: Balanced Partitioning tests currently hang on ARM.
+#if defined(__arm__)
+#define SKIP_UNSUPPORTED_PLATFORM GTEST_SKIP()
+#else
+#define SKIP_UNSUPPORTED_PLATFORM do { } while(0)
+#endif
+
 namespace llvm {
 
 void PrintTo(const BPFunctionNode &Node, std::ostream *OS) {
@@ -40,6 +47,7 @@ class BalancedPartitioningTest : public ::testing::Test {
 };
 
 TEST_F(BalancedPartitioningTest, Basic) {
+  SKIP_UNSUPPORTED_PLATFORM;
   std::vector<BPFunctionNode> Nodes = {
       BPFunctionNode(0, {1, 2}), BPFunctionNode(2, {3, 4}),
       BPFunctionNode(1, {1, 2}), BPFunctionNode(3, {3, 4}),
@@ -59,6 +67,7 @@ TEST_F(BalancedPartitioningTest, Basic) {
 }
 
 TEST_F(BalancedPartitioningTest, Large) {
+  SKIP_UNSUPPORTED_PLATFORM;
   const int ProblemSize = 1000;
   std::vector<BPFunctionNode::UtilityNodeT> AllUNs;
   for (int i = 0; i < ProblemSize; i++)
@@ -85,6 +94,7 @@ TEST_F(BalancedPartitioningTest, Large) {
 }
 
 TEST_F(BalancedPartitioningTest, MoveGain) {
+  SKIP_UNSUPPORTED_PLATFORM;
   BalancedPartitioning::SignaturesT Signatures = {
       {10, 10, 10.f, 0.f, true}, // 0
       {10, 10, 0.f, 10.f, true}, // 1


        


More information about the llvm-commits mailing list