[PATCH] D152333: update_mir_test_checks.py doesn't separate different prefix checks #63112

Eddie Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 11:02:17 PDT 2023


eddiep24 updated this revision to Diff 529372.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152333/new/

https://reviews.llvm.org/D152333

Files:
  llvm/utils/update_mir_test_checks.py


Index: llvm/utils/update_mir_test_checks.py
===================================================================
--- llvm/utils/update_mir_test_checks.py
+++ llvm/utils/update_mir_test_checks.py
@@ -235,9 +235,10 @@
                 break
             if not func_dict[prefix][func_name]:
                 continue
-            # if printed_prefixes:
-            #     # Add some space between different check prefixes.
-            #     output_lines.append('')
+            if printed_prefixes:
+                # Add some space between different check prefixes.
+                indent = len(output_lines[-1]) - len(output_lines[-1].lstrip(" "))
+                output_lines.append(" "*indent + ";")
             printed_prefixes.add(prefix)
             log("Adding {} lines for {}".format(prefix, func_name), args.verbose)
             add_check_lines(
@@ -333,9 +334,9 @@
 
 
 def should_add_line_to_output(input_line, prefix_set):
-    # Skip any check lines that we're handling.
+    # Skip any check lines that we're handling as well as comments
     m = common.CHECK_RE.match(input_line)
-    if m and m.group(1) in prefix_set:
+    if (m and m.group(1) in prefix_set) or re.search("^[ \t]*;", input_line):
         return False
     return True
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152333.529372.patch
Type: text/x-patch
Size: 1259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230607/2b233da6/attachment.bin>


More information about the llvm-commits mailing list