[PATCH] D147812: [InstrProf] Use BalancedPartitioning to order temporal profiling trace data

Leandro Lupori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 10:52:41 PDT 2023


luporl added a comment.

In D147812#4403792 <https://reviews.llvm.org/D147812#4403792>, @ellis wrote:

> In D147812#4403228 <https://reviews.llvm.org/D147812#4403228>, @luporl wrote:
>
>> The show-order.proftext test never finishes on armhf, causing a timeout in `ninja check-all` and a failure in this build bot: https://lab.llvm.org/buildbot/#/builders/178
>
> Looking now. I suspect this is related to the fact that threads are disabled (`-DLLVM_ENABLE_THREADS=OFF`). I don't see any mention of the `show-order.proftext` test in the job. Have you reproduced locally?

Sorry, I saw your message after having just disabled the tests on ARM, to get the build bot working again. But we can revert it as soon as they are fixed.

I have been able to reproduce it locally, both `show-order.proftext` and `BalancedPartitioningTest` just hang and never finish. They don't consume any significant amount of CPU or memory. It seems like they are waiting for something.

I guess the tests weren't printed in the bot logs because they haven't passed or failed, they were still being executed when the timeout killed them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147812/new/

https://reviews.llvm.org/D147812



More information about the llvm-commits mailing list