[PATCH] D152005: [SVE ACLE] Implement IR combines to convert intrinsics used for _m C/C++ builtins

Wed Jun 7 09:36:44 PDT 2023

mgabka added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/AArch64/sve-intrinsic-m-to-x.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt -S -passes=instcombine < %s | FileCheck %s
----------------
jolanta.jensen wrote:
> mgabka wrote:
> > I am not a big fan of the name of this file, it suggests that there should be intrinsics with _x or _m suffix being used but there no such ones.
> > 
> > I think it would also be good to sort the test in alphabetical order by the name of the intrinsic being tested, that would make navigation through this long file easier.
> _x and _m suffixes were inspired by [[ https://developer.arm.com/architectures/instruction-sets/intrinsics | acle docs ]]. I happily take suggestions to rename the file.
> 
> Shall the alphabetical sorting be for the whole file or within the sections, i.e. within Float arithmetics, Integer arithmetics, Shifts and Logical operations?
both options are fine, I think the one you proposed sounds better.

Yeah I know from where the _x and _m is coming, I just think that in this case it would be easier to use file name like sve-intrinsics-combine-to-u-forms.ll or something simialar

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152005/new/

https://reviews.llvm.org/D152005