[PATCH] D152363: [llvm-dlltool] Implement the --no-leading-underscore option

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/lib/Object/COFFModuleDefinition.cpp:143
+      : Lex(S), Machine(M), MingwDef(B), AddUnderscores(AU) {
+    if (Machine != IMAGE_FILE_MACHINE_I386)
+      AddUnderscores = false;
----------------
mati865 wrote:
> I know nothing about ARM on Windows so double-check it but shouldn't this also check for ARM?
Nope, out of the current 4 active architectures, only i386 uses such prefixes. And I don’t think the other ones (alpha, mips, sh4, ppc, ia64) used any prefix either, but I don’t know for sure about them.

In most cases, i386 is the weirdo - https://devblogs.microsoft.com/oldnewthing/20040914-00/?p=37873


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152363/new/

https://reviews.llvm.org/D152363