[PATCH] D152363: [llvm-dlltool] Implement the --no-leading-underscore option
Mateusz MikuĊa via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 7 07:32:45 PDT 2023
mati865 added inline comments.
================
Comment at: llvm/lib/Object/COFFModuleDefinition.cpp:143
+ : Lex(S), Machine(M), MingwDef(B), AddUnderscores(AU) {
+ if (Machine != IMAGE_FILE_MACHINE_I386)
+ AddUnderscores = false;
----------------
I know nothing about ARM on Windows so double-check it but shouldn't this also check for ARM?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152363/new/
https://reviews.llvm.org/D152363
More information about the llvm-commits
mailing list