[PATCH] D152362: [llvm-lib] Pass the right value of MingwDef to parseCOFFModuleDefinition

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: hans, vadikp-intel, alvinhochun.
Herald added a subscriber: hiraditya.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

In llvm-lib cases, the MinGW specific behaviours shouldn't be
enabled.

Not adding any tests to check the corner case behaviours, as this
simply was a mistake when this codepath was added in
395ec4458fb7fc700551f7017c0a395d68c55873 <https://reviews.llvm.org/rG395ec4458fb7fc700551f7017c0a395d68c55873> / D144765 <https://reviews.llvm.org/D144765>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152362

Files:
  llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp


Index: llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp
===================================================================
--- llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp
+++ llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp
@@ -384,7 +384,7 @@
     }
 
     Expected<COFFModuleDefinition> Def =
-        parseCOFFModuleDefinition(*MB, LibMachine, true);
+        parseCOFFModuleDefinition(*MB, LibMachine, /*MingwDef=*/false);
 
     if (!Def) {
       llvm::errs() << "error parsing definition\n"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152362.529253.patch
Type: text/x-patch
Size: 489 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230607/5c0d07c9/attachment.bin>