[PATCH] D152361: [llvm-dlltool] Ignore the --temp-prefix option

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: alvinhochun, mati865, jeremyd2019.
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

llvm-dlltool tolerates unknown options as long as they are plain
flags, but if given the parameter value as a separate argument,
e.g. "--temp-prefix foo", it fails to ignore it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152361

Files:
  llvm/lib/ToolDrivers/llvm-dlltool/Options.td
  llvm/test/tools/llvm-dlltool/ignored-opts.def


Index: llvm/test/tools/llvm-dlltool/ignored-opts.def
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-dlltool/ignored-opts.def
@@ -0,0 +1,8 @@
+; RUN: llvm-dlltool -m i386 -d %s -l %t.a --temp-prefix foo
+; RUN: llvm-dlltool -m i386 -d %s -l %t.a --temp-prefix=foo
+; RUN: llvm-dlltool -m i386 -d %s -l %t.a -t foo
+; RUN: llvm-dlltool -m i386 -d %s -l %t.a -tfoo
+
+LIBRARY test.dll
+EXPORTS
+TestFunction
Index: llvm/lib/ToolDrivers/llvm-dlltool/Options.td
===================================================================
--- llvm/lib/ToolDrivers/llvm-dlltool/Options.td
+++ llvm/lib/ToolDrivers/llvm-dlltool/Options.td
@@ -24,3 +24,6 @@
 
 def f: JoinedOrSeparate<["-"], "f">, HelpText<"Assembler Flags">;
 def f_alias: JoinedOrSeparate<["--"], "as-flags">, Alias<f>;
+
+def t: JoinedOrSeparate<["-"], "t">, HelpText<"Prefix for temporary files (ignored)">;
+def t_alias: JoinedOrSeparate<["--"], "temp-prefix">, Alias<f>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152361.529252.patch
Type: text/x-patch
Size: 987 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230607/9cca0dfc/attachment.bin>