[PATCH] D152359: [COFF] Remove misleading and unclear comments. NFC.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 04:38:52 PDT 2023

mstorsjo created this revision.
mstorsjo added reviewers: alvinhochun, mati865, jeremyd2019.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

It is not planned that GNU binutils would change this aspect of
its behaviour wrt how symbol decoration is done.

  rG LLVM Github Monorepo



Index: llvm/include/llvm/Object/COFFModuleDefinition.h
--- llvm/include/llvm/Object/COFFModuleDefinition.h
+++ llvm/include/llvm/Object/COFFModuleDefinition.h
@@ -39,9 +39,6 @@
   uint32_t MinorOSVersion = 0;
-// mingw and wine def files do not mangle _ for x86 which
-// is a consequence of legacy binutils' dlltool functionality.
-// This MingwDef flag should be removed once mingw stops this pratice.
 parseCOFFModuleDefinition(MemoryBufferRef MB, COFF::MachineTypes Machine,
                           bool MingwDef = false);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152359.529249.patch
Type: text/x-patch
Size: 636 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230607/cce683cc/attachment.bin>

More information about the llvm-commits mailing list