[PATCH] D152333: update_mir_test_checks.py doesn't separate different prefix checks #63112

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 02:07:15 PDT 2023


RKSimon added a comment.

By the looks of it repeatedly running the script on a file adds newlines at the top of each function's set of checks? These shouldn't occur



================
Comment at: llvm/utils/update_mir_test_checks.py:240
+                # Add some space between different check prefixes.
+                output_lines.append('')
             printed_prefixes.add(prefix)
----------------
ideally this would be an indented ';' and not just an empty line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152333/new/

https://reviews.llvm.org/D152333



More information about the llvm-commits mailing list