[PATCH] D152348: [InstCombine] Canonicalize (icmp eq/ne X, rotate(X)) to always use rotate-left

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

It looks like you mixed up the descriptions of the two patches maybe?



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3493
+            Builder.CreateCall(
+                Rotate, {IIOp0->getOperand(0), IIOp0->getOperand(0), SubAmt}));
+        }
----------------
Use CreateIntrinsicCall instead of fetching the declaration manually?


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3495
+        }
+    }
+    break;
----------------
Broken indents


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152348/new/

https://reviews.llvm.org/D152348