[PATCH] D152286: [Option] Support special argument "--"

Wed Jun 7 01:45:21 PDT 2023

hans added a comment.

In D152286#4400088 <https://reviews.llvm.org/D152286#4400088>, @MaskRay wrote:

> (CC @hans Just noticed that you have D1387 <https://reviews.llvm.org/D1387> which `allows us to remove the hard-coded handling of "--"`. 
> I don't find `DASH_DASH` in modern lld, but Clang does have a special case.)

Thanks! The motivation for introducing `KIND_REMAINING_ARGS` was to support the `/link` flag. I think at the time I figured it was more elegant that `--` could now be implemented with the regular option parsing machinery rather than hard-coding, but as you say since most option parsing libraries support `--`, maybe it makes sense to put the hard-coded behavior back.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152286/new/

https://reviews.llvm.org/D152286