[PATCH] D150870: [lld][Arm] Big Endian - Byte invariant support.

[Simi Pallipurath via Phabricator via llvm-commits]

simpal01 marked 12 inline comments as done.
simpal01 added inline comments.


================
Comment at: lld/ELF/Arch/ARM.cpp:939
+  // Collect mapping symbols for every executable InputSection.
+  for (const SymbolTableEntry &entry : in.symTab->getSymbols()) {
+    auto *def = dyn_cast<Defined>(entry.sym);
----------------
MaskRay wrote:
> `in.symTab` will be null with `--strip-all`
Yeah. you are right. I didn't notice that until you say. Thank you. Now i am collecting mapping symbols separately between synthetic and non synthetic local symbols.  Adding Linker generated mapping symbols through the function addArmMappingSymbols() when linker generated symbols are added via addSyntheticLocal.



================
Comment at: lld/test/ELF/arm-be8-check.s:1
+# REQUIRES: arm
+# RUN: llvm-mc -filetype=obj -triple=armv7-a-none-eabi --arm-add-build-attributes %s -o %t
----------------
MaskRay wrote:
> What's the purpose of the new test when there are other thunk tests have got the --be8 test?
Removed this test


================
Comment at: lld/test/ELF/arm-be8-thunks.s:1
+# REQUIRES: arm
+# RUN: rm -rf %t && split-file %s %t
----------------
MaskRay wrote:
> What's the purpose of the new test when there are other thunk tests have got the `--be8` test?
there were not any test which checks the hex dump content of the executable sections. Now moved this checking to arm-thunk-reuse.s


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150870/new/

https://reviews.llvm.org/D150870