[llvm] 1794532 - [InstrProf] Move BPFunctionNode test to ProfileDataTests

[Ellis Hoag via llvm-commits]

Author: Ellis Hoag
Date: 2023-06-06T19:12:51-07:00
New Revision: 1794532bb942bac9b82b6817e349210b6aafaaa9

URL: https://github.com/llvm/llvm-project/commit/1794532bb942bac9b82b6817e349210b6aafaaa9
DIFF: https://github.com/llvm/llvm-project/commit/1794532bb942bac9b82b6817e349210b6aafaaa9.diff

LOG: [InstrProf] Move BPFunctionNode test to ProfileDataTests

In https://reviews.llvm.org/D147812 I created
`BalancedPartitioningTest.cpp` and inadvertently drastically increased the
number of files needed to compile `SupportTests`. Instead lets move the
`BPFunctionNode` test to `unittests/ProfileData` so we can remove the
extra dependency.

Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D152325

Added: 
    llvm/unittests/ProfileData/BPFunctionNodeTest.cpp

Modified: 
    llvm/unittests/ProfileData/CMakeLists.txt
    llvm/unittests/Support/BalancedPartitioningTest.cpp
    llvm/unittests/Support/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/ProfileData/BPFunctionNodeTest.cpp b/llvm/unittests/ProfileData/BPFunctionNodeTest.cpp
new file mode 100644
index 0000000000000..97ff5c1edf5ef
--- /dev/null
+++ b/llvm/unittests/ProfileData/BPFunctionNodeTest.cpp
@@ -0,0 +1,45 @@
+//===- BPFunctionNodeTest.cpp - BPFunctionNode tests ----------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/ProfileData/InstrProf.h"
+#include "llvm/Support/BalancedPartitioning.h"
+#include "llvm/Testing/Support/SupportHelpers.h"
+#include "gmock/gmock.h"
+#include "gtest/gtest.h"
+
+using testing::Field;
+using testing::UnorderedElementsAre;
+using testing::UnorderedElementsAreArray;
+
+namespace llvm {
+
+void PrintTo(const BPFunctionNode &Node, std::ostream *OS) {
+  raw_os_ostream ROS(*OS);
+  Node.dump(ROS);
+}
+
+TEST(BPFunctionNodeTest, Basic) {
+  auto Nodes = TemporalProfTraceTy::createBPFunctionNodes({
+      TemporalProfTraceTy({0, 1, 2, 3, 4}),
+      TemporalProfTraceTy({4, 2}),
+  });
+
+  auto NodeIs = [](BPFunctionNode::IDT Id,
+                   ArrayRef<BPFunctionNode::UtilityNodeT> UNs) {
+    return AllOf(Field("Id", &BPFunctionNode::Id, Id),
+                 Field("UtilityNodes", &BPFunctionNode::UtilityNodes,
+                       UnorderedElementsAreArray(UNs)));
+  };
+
+  EXPECT_THAT(Nodes,
+              UnorderedElementsAre(NodeIs(0, {0, 1, 2}), NodeIs(1, {1, 2}),
+                                   NodeIs(2, {1, 2, 4, 5}), NodeIs(3, {2}),
+                                   NodeIs(4, {2, 3, 4, 5})));
+}
+
+} // end namespace llvm

diff  --git a/llvm/unittests/ProfileData/CMakeLists.txt b/llvm/unittests/ProfileData/CMakeLists.txt
index 3fbdd85ff0ce6..ce3a0a45ccf18 100644
--- a/llvm/unittests/ProfileData/CMakeLists.txt
+++ b/llvm/unittests/ProfileData/CMakeLists.txt
@@ -7,6 +7,7 @@ set(LLVM_LINK_COMPONENTS
   )
 
 add_llvm_unittest(ProfileDataTests
+  BPFunctionNodeTest.cpp
   CoverageMappingTest.cpp
   InstrProfDataTest.cpp
   InstrProfTest.cpp

diff  --git a/llvm/unittests/Support/BalancedPartitioningTest.cpp b/llvm/unittests/Support/BalancedPartitioningTest.cpp
index a71e19c3a2392..ebe518a8e89ca 100644
--- a/llvm/unittests/Support/BalancedPartitioningTest.cpp
+++ b/llvm/unittests/Support/BalancedPartitioningTest.cpp
@@ -7,12 +7,10 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/Support/BalancedPartitioning.h"
-#include "llvm/ProfileData/InstrProf.h"
 #include "llvm/Testing/Support/SupportHelpers.h"
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
 
-using namespace llvm;
 using testing::Each;
 using testing::Field;
 using testing::Not;
@@ -26,25 +24,6 @@ void PrintTo(const BPFunctionNode &Node, std::ostream *OS) {
   Node.dump(ROS);
 }
 
-TEST(BPFunctionNodeTest, Basic) {
-  auto Nodes = TemporalProfTraceTy::createBPFunctionNodes({
-      TemporalProfTraceTy({0, 1, 2, 3, 4}),
-      TemporalProfTraceTy({4, 2}),
-  });
-
-  auto NodeIs = [](BPFunctionNode::IDT Id,
-                   ArrayRef<BPFunctionNode::UtilityNodeT> UNs) {
-    return AllOf(Field("Id", &BPFunctionNode::Id, Id),
-                 Field("UtilityNodes", &BPFunctionNode::UtilityNodes,
-                       UnorderedElementsAreArray(UNs)));
-  };
-
-  EXPECT_THAT(Nodes,
-              UnorderedElementsAre(NodeIs(0, {0, 1, 2}), NodeIs(1, {1, 2}),
-                                   NodeIs(2, {1, 2, 4, 5}), NodeIs(3, {2}),
-                                   NodeIs(4, {2, 3, 4, 5})));
-}
-
 class BalancedPartitioningTest : public ::testing::Test {
 protected:
   BalancedPartitioningConfig Config;

diff  --git a/llvm/unittests/Support/CMakeLists.txt b/llvm/unittests/Support/CMakeLists.txt
index ad0e658eba3ad..9b550b9b31112 100644
--- a/llvm/unittests/Support/CMakeLists.txt
+++ b/llvm/unittests/Support/CMakeLists.txt
@@ -1,5 +1,4 @@
 set(LLVM_LINK_COMPONENTS
-  ProfileData
   Support
   TargetParser
   )