[PATCH] D151979: [RISCV] Handle "o" inline asm memory constraint

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/inline-asm.ll:116
+; RV64I-NEXT:    ret
+  call void asm sideeffect "", "=*o"(ptr elementtype(i32) %a)
+  ret void
----------------
pcwang-thead wrote:
> jrtc27 wrote:
> > The implementation could be completely broken and this would be none the wiser. You need to test the implementation actually lowers it to something sensible, not that it doesn't crash.
> These tests are the same as constraint "m" now.
Thanks for the update. The previous case is what I call

https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer#the-test-checks-too-little  "A regression test which simply runs the compiler and expects it not to crash has low utilization. It is often better to additionally test some properties of the produced object file."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151979/new/

https://reviews.llvm.org/D151979