[PATCH] D152221: Avoid cross-section branches in AArch64 inline asm

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 14:41:13 PDT 2023


nickdesaulniers added a comment.

In D152221#4401085 <https://reviews.llvm.org/D152221#4401085>, @efriedma wrote:

>> Perhaps the label should be defined in C, then asm goto should be used for the first inline asm statement
>
> Sure, but we don't need to disable function splitting and bb sections to handle that case.  The distance between an "asm goto" and its destination doesn't matter; we can apply branch relaxation like we would for normal conditional branches.

Right; so we're in agreement the code in question (outside of LLVM) should be rewritten.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152221/new/

https://reviews.llvm.org/D152221



More information about the llvm-commits mailing list