[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.
Brendan Dahl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 6 13:40:54 PDT 2023
brendandahl marked 2 inline comments as done.
brendandahl added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7638
+ D->addAttr(::new (S.Context) WebAssemblyAsyncAttr(S.Context, AL));
+ D->addAttr(UsedAttr::CreateImplicit(S.Context));
+}
----------------
erichkeane wrote:
> We should probably document that this forces the function to be emitted as well.
I've removed this since we won't actually always want these functions preserved. I've changed the linker to now put a tombstone in the async section instead. I also added a new test for this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150803/new/
https://reviews.llvm.org/D150803
More information about the llvm-commits
mailing list