[PATCH] D152282: [Transforms][LICM] A test case for the upcoming fix D152281 for the issue with reassociation profitability

Tue Jun 6 13:12:11 PDT 2023

fhahn added inline comments.

================
Comment at: llvm/test/Transforms/LICM/expr-reassociate.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt -passes='reassociate' -S < %s | FileCheck %s --check-prefix=REASSOCIATE_ONLY
+; RUN: opt -passes='licm' -S < %s | FileCheck %s --check-prefix=LICM_ONLY
----------------
Usually the tests for a specific transform shouldn't depend on other passes; You could add a test to `PhaseOrdering` that tests the end-to-end flow (e.g. with -O2) and then here have just the ones that run `licm` on the input IR that requires reassoication to move it out of the loop

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152282/new/

https://reviews.llvm.org/D152282