[PATCH] D152261: [CodeGen] Move lowerCopy from expandPostRA to TII

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetInstrInfo.cpp:721-724
+bool TargetInstrInfo::lowerCopy(MachineInstr *MI) const {
+  const MachineFunction *MF = MI->getParent()->getParent();
+  const TargetInstrInfo *TII = MF->getSubtarget().getInstrInfo();
+  const TargetRegisterInfo *TRI = MF->getSubtarget().getRegisterInfo();
----------------
Should pass in TRI for consistency with other TRI functions 


================
Comment at: llvm/lib/CodeGen/TargetInstrInfo.cpp:728
+    MI->setDesc(TII->get(TargetOpcode::KILL));
+    return true;
+  }
----------------
Don't see the point of the bool return, it just always returns true


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152261/new/

https://reviews.llvm.org/D152261