[PATCH] D152116: [X86] Transform `(icmp eq/ne (and X, C0), (shift X, C1))` to get better constants.

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 11:55:00 PDT 2023


goldstein.w.n added a comment.

In D152116#4400494 <https://reviews.llvm.org/D152116#4400494>, @RKSimon wrote:

> I suppose I'm asking was whether this patch is x86 specific or not - it's always nice not to have something in X86ISelLowering.cpp if other targets would benefit

Ah I see. Happy to move to DAGCombiner and put this behind something like TargetLowing::PreferInvertShiftAndMask.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152116/new/

https://reviews.llvm.org/D152116



More information about the llvm-commits mailing list