[PATCH] D151996: [AMDGPU] Start documenting calling conventions. NFC

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

Can you reupload with full context? If you're using the web interface I think https://www.llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface is still accurate, so something like:

  git show HEAD -U999999 > mypatch.patch

I ask because I think this should be cross-referenced with (or maybe even combined with) the existing `Call Convention` docs around line ~13500:

  Call Convention
  ~~~~~~~~~~~~~~~
  
  .. note::
  
    This section is currently incomplete and has inaccuracies. It is WIP that will
    be updated as information is determined.
  
  See :ref:`amdgpu-dwarf-address-space-identifier` for information on swizzled
  addresses. Unswizzled addresses are normal linear addresses.
  
  .. _amdgpu-amdhsa-function-call-convention-kernel-functions:
  
  Kernel Functions
  ++++++++++++++++
  
  This section describes the call convention ABI for the outer kernel function.
  ...



================
Comment at: llvm/docs/AMDGPUUsage.rst:1039
 
+Calling conventions
+-------------------
----------------
Nit: capitalize


================
Comment at: llvm/docs/AMDGPUUsage.rst:1049
+     Calling Convention              Description
+     =============================== ==========================================================
+     ``amdgpu_vs``                   Used for Mesa vertex shaders, or AMDPAL last shader stage before
----------------
The omission of the default `ccc` convention seems like it might lead to confusion. The backend supports it, so I would suggest just adding it at the front of the list and making it clear that it is the default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151996/new/

https://reviews.llvm.org/D151996