[PATCH] D147740: [llvm-profdata] Refactoring Sample Profile Reader to increase FDO build speed using MD5 as key to Sample Profile map
William Junda Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 6 11:42:32 PDT 2023
huangjd marked 2 inline comments as done.
huangjd added inline comments.
================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:1301
+ Ret.second = true;
+ Ret.first->second = mapped_type();
+ }
----------------
davidxl wrote:
> potential memory leak? Also why inserting an empty FunctionSamples instead of the one passed in?
Fixed. FunctionSamples is copy assignable
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147740/new/
https://reviews.llvm.org/D147740
More information about the llvm-commits
mailing list