[PATCH] D149488: [RISCV] Use AMOSWAP for 32 and 64-bit atomic stores

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:10098
+// returns true for seq_cst stores of 32/64bit
+bool canAmoSwapStoreInst(const StoreInst *SI, const RISCVSubtarget &Subtarget) {
+  unsigned Size = SI->getValueOperand()->getType()->getPrimitiveSizeInBits();
----------------
craig.topper wrote:
> I think LLVM coding guidelines are to use `static` for functions rather than anonymous namespace. https://llvm.org/docs/CodingStandards.html#anonymous-namespaces
huh, I could have sworn we preferred the anonymous namespace, but obviously not. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149488/new/

https://reviews.llvm.org/D149488