[PATCH] D134756: [BOLT] introducing profi params

Tue Jun 6 09:38:33 PDT 2023

Amir added a comment.

In D134756#4399936 <https://reviews.llvm.org/D134756#4399936>, @spupyrev wrote:

> In D134756#4397850 <https://reviews.llvm.org/D134756#4397850>, @Amir wrote:
>
>> Why was this specific change needed?
>>
>>> introducing an object holding the algorithmic parameters;
>>
>> Is it in order to specify different BOLT defaults? Or for the theoretical use case where BOLT and Clang are both invoked from the same driver, as in llvm-driver build mode?
>
> BOLT and CSSPGO are using different profi parameters, as they're based on different profiles. This diff allows to pass the params for the algorithm

In that case, it's possible to override these parameters from BOLT – just like we do for some other knobs in adjustCommandLineOptions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134756/new/

https://reviews.llvm.org/D134756