[PATCH] D152157: [AppleAccelTable] Keep track of the size of each hash data entry

Tue Jun 6 09:19:48 PDT 2023

JDevlieghere accepted this revision.
JDevlieghere added a comment.

LGTM

================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h:109
   dwarf::FormParams FormParams;
+  uint32_t HashDataEntryLength;
   bool IsValid = false;
----------------
fdeazeve wrote:
> aprantl wrote:
> > should this be default-initialized?
> I believe the design of this class is that it should not be used until `IsValid` is set to true, and `IsValid` is only set to true after all of its members are initialized.
> 
> We could clean this up by moving away from the declare(ctor)-then-initialize (`extract`) anti-pattern, instead making sure the constructor does all the way
+1: moving away from that would be great. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152157/new/

https://reviews.llvm.org/D152157