[PATCH] D127115: [DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Tue Jun 6 08:07:32 PDT 2023

deadalnix added a comment.

In D127115#4399535 <https://reviews.llvm.org/D127115#4399535>, @n-omer wrote:

> We've also identified this issue in an internal codebase built with this patch, the problem is that `// X != Y   -->  (X^Y)` in `TargetLowering::SimplifySetCC` and `Transform (brcond (xor x, y)) -> (brcond (setcc, x, y, ne))` in `DAGCombiner::rebuildSetCC` keep undoing each other without an end:

That seems relatively easy to fix, the question is, which one do we want?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115