[PATCH] D152273: [RISCV] Don't persist invalid feature state on .option arch error

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 07:52:44 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/MC/RISCV/option-invalid.s:50
 
+## Make sure the above error isn't sticky
+# CHECK-NOT: :[[#@LINE+1]]:
----------------
jrtc27 wrote:
> MaskRay wrote:
> > 
> Short comments don't normally get full stops?
In comments, a complete sentence gets a full stop. An incomplete one doesn't.
There may be cases where a short complete sentence doesn't get a full stop, but I think we don't encourage that:)

(
As a difference, diagnostic messages typically do not get full stops
https://llvm.org/docs/CodingStandards.html#error-and-warning-messages
)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152273/new/

https://reviews.llvm.org/D152273



More information about the llvm-commits mailing list