[PATCH] D150922: [KnownBits] Return `0` for poison {s,u}div inputs

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 05:33:01 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Support/KnownBits.cpp:754
+  if (LHS.isZero() || RHS.isZero()) {
+    // Result is either known Zero or Poison. Return Zero either way.
+    // Checking this earlier saves us a lot of special cases later on.
----------------
nit: Poison -> UB


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150922/new/

https://reviews.llvm.org/D150922



More information about the llvm-commits mailing list