[PATCH] D152063: [AVR] Support left-rotations

Patryk Wychowaniec via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 02:47:45 PDT 2023


Patryk27 added inline comments.


================
Comment at: llvm/test/CodeGen/AVR/pseudo/ROLBrd.mir:24-28
-
-    ; avrtiny variant
-    ; CHECK:      $r14 = ADDRdRr killed $r14, killed $r14, implicit-def $sreg
-    ; CHECK-NEXT: $r14 = ADCRdRr $r14, $r17, implicit-def dead $sreg, implicit killed $sreg
-    $r14 = ROLBRd $r14, $r17, implicit-def $sreg
----------------
aykevl wrote:
> Why did you remove this test? I think it's useful (r1 vs r17).
I removed the second assertion since the zero-register is not an input for that instruction anymore - I guess using two-pass test with `--check-prefix` (once for `r1` and once for `r17`) would be nice here, though


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152063/new/

https://reviews.llvm.org/D152063



More information about the llvm-commits mailing list