[PATCH] D151995: [AMDGPU] Add llvm.amdgcn.cs.chain intrinsic to IR & verifier
Ruiling, Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 6 00:52:15 PDT 2023
ruiling added inline comments.
================
Comment at: llvm/test/Verifier/AMDGPU/intrinsic-amdgpu-cs-chain.ll:10
+ call void(ptr, i32, <4 x i32>, { ptr, <3 x i32> }, i32, ...) @llvm.amdgcn.cs.chain(ptr %fn, i32 %exec, <4 x i32> %sgpr, { ptr, <3 x i32> } %vgpr, i32 %flags)
+ ret void
+}
----------------
A minor suggestion: as cs.chain is marked as NoRet, it may be more proper to use unreachable here instead of ret.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151995/new/
https://reviews.llvm.org/D151995
More information about the llvm-commits
mailing list