[PATCH] D152222: [RISCV] Fix the num of chain SDNode introduced in 9e0f9f113248093e737c4cf5450f0a3c2bcd90ba
Zixuan Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 5 23:06:20 PDT 2023
zixuan-wu added a comment.
In D152222#4398201 <https://reviews.llvm.org/D152222#4398201>, @craig.topper wrote:
> Ok I looked closer at the code. Neither isProfitableToFold or isLegalToFold are implemented in this file. I think we could add an override of isProfitableToFold, but might not be worth it. We can reject load update this code near where we call isProfitableToFold/isLegalToFold.
Yes, and I also think it makes sense more because rejecting load update is not common logic to add to isProfitableToFold/isLegalToFold.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152222/new/
https://reviews.llvm.org/D152222
More information about the llvm-commits
mailing list