[PATCH] D152193: [RISCV] Rework .option arch target streamer interface
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 5 19:23:42 PDT 2023
jrtc27 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2743
- getTargetStreamer().emitDirectiveOptionArchFullArch(Result,
- PrefixEmitted);
-
+ Args.emplace_back(Type, Result);
break;
----------------
craig.topper wrote:
> jrtc27 wrote:
> > NB: This is the reason for using std::string rather than StringRef in RISCVOptionArchArg
> Why do we need to emit a canonical ISA string instead of what was passed?
This is a good question, especially when we *don't* include a version number for `.option arch, [+-]`... dunno what makes more sense, but this was intended to be NFC (as was the dependency, modulo diagnostics)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152193/new/
https://reviews.llvm.org/D152193
More information about the llvm-commits
mailing list