[PATCH] D150415: [RISCV] Add a pass to merge moving parameter registers instructions for Zcmp

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVMoveOptimizer.cpp:181
+// merged into CM.MVA01S or CM.MVSA01.
+bool RISCVMoveOpt::MergeMoveSARegPair(MachineBasicBlock &MBB) {
+  bool Modified = false;
----------------
Function names should start with a lower case letter


================
Comment at: llvm/lib/Target/RISCV/RISCVMoveOptimizer.cpp:203
+          findMatchingInst(MBBI, Opcode, RegPair.value());
+      // If matching instruction could be found merge them.
+      if (Paired != E) {
----------------
could -> can


================
Comment at: llvm/lib/Target/RISCV/RISCVMoveOptimizer.cpp:231
+  bool Modified = false;
+  for (auto &MBB : Fn) {
+    Modified |= MergeMoveSARegPair(MBB);
----------------
Drop the curly braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150415/new/

https://reviews.llvm.org/D150415