[PATCH] D152193: [RISCV] Rework .option arch target streamer interface

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2743
 
-        getTargetStreamer().emitDirectiveOptionArchFullArch(Result,
-                                                            PrefixEmitted);
-
+        Args.emplace_back(Type, Result);
         break;
----------------
jrtc27 wrote:
> NB: This is the reason for using std::string rather than StringRef in RISCVOptionArchArg
Why do we need to emit a canonical ISA string instead of what was passed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152193/new/

https://reviews.llvm.org/D152193