[PATCH] D152192: [RISCV] Make .option arch parser less mind-bending
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 5 15:50:45 PDT 2023
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2745
+
+ if (IsFull) {
std::string Result;
----------------
I think you could use `!IsExtensionList` here and avoid the `IsFull` flag. That might make the code less readable, but maybe that can be fixed with renaming `IsExtensionList`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152192/new/
https://reviews.llvm.org/D152192
More information about the llvm-commits
mailing list