[PATCH] D144653: [BOLT][AArch64] ST_Function symbols start a CODE interval

Mon Jun 5 15:04:14 PDT 2023

maksfb added a comment.

@sebpop According to ABI's (IHI0056B) "5.4.5 Mapping symbols":

  Mapping symbols defined in a section (relocatable view) or segment (executable view) define a sequence of halfopen intervals that cover the address range of the section or segment. Each interval starts at the address defined
  by the mapping symbol, and continues up to, but not including, the address defined by the next (in address order) mapping symbol or the end of the section or segment.

I.e. the code should resume with `$x/$x.<any>` mapping symbol in addition to `ST_Function`, but it's not.

Is the problematic code coming from lua compiler/assembler? If it's not possible to fix lua, I think it's okay to introduce the check for `ST_Function` and issue a warning. Unless o/c there are legitimate cases where `ST_Function` could be data (?). @yota9, does this make sense to you?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144653/new/

https://reviews.llvm.org/D144653