[PATCH] D148283: [ExecutionEngine] Support TargetExtType in Interpreter

[Joshua Cranmer via Phabricator via llvm-commits]

jcranmer-intel added a comment.

Sorry for the delay in reviewing this patch.

I'm not an expert in the JIT code, so I'm not completely certain that this code covers all the bases (in particular, it's somewhat unclear to me if this is handling globals correctly).

You should be able to add a test for this code along the lines of test/ExecutionEngine/test-interp-aggregate.ll, that would at least make sure that load/store, global variables, ConstantTargetNone, and poison value initializers work correctly. That would definitely make me more comfortable re the global variable support.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148283/new/

https://reviews.llvm.org/D148283