[PATCH] D152177: [Demangle] refactor DLangDemangle to use std::string_view

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 13:14:35 PDT 2023


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:228
+    return false;
+  }
 
----------------
This code isn't necessary?  The while loop contains an equivalent guard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152177/new/

https://reviews.llvm.org/D152177



More information about the llvm-commits mailing list