[PATCH] D151933: [DebugInfo] Return an error from DWARFUnitHeader::applyIndexEntry

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

> I realize this should have a test as well. I didn't find any existing tests that I could easily extend so if anybody has any suggestions for a way to construct a test, please let me know!

Yeah, would be good to have test coverage. I'd start by adding an `assert(false)` to the function you're modifying (or maybe just to one of the error paths, though it's likely they're not so well tested/might not have coverage) - to identify some test cases that exercise this code,t hen maybe you can extend those tests or create new ones inspired by the existing ones?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151933/new/

https://reviews.llvm.org/D151933