[PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 09:59:40 PDT 2023


efriedma added inline comments.


================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555
 
-    Demangler D = Demangler(MangledName);
-    MangledName = D.parseMangle(&Demangled);
+    Demangler D(MangledName.data());
+    const char *M = D.parseMangle(&Demangled);
----------------
Isn't this still assuming MangledName is null-terminated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151003/new/

https://reviews.llvm.org/D151003



More information about the llvm-commits mailing list