[PATCH] D152173: [NFC] Remove outdated TODO for `Type::getPointerTo`

Youngsuk Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 08:53:51 PDT 2023


JOE1994 created this revision.
Herald added a project: All.
JOE1994 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

D104718 <https://reviews.llvm.org/D104718> (commit 7bb7fa12e73b <https://reviews.llvm.org/rG7bb7fa12e73bd3c9fb66f05825758d729dd96ba5>) introduced the TODO comment, along with
code for opaque pointer handling in `Type::getPointerTo`.

Later, D104902 <https://reviews.llvm.org/D104902> (commit 1e6303e60ca5 <https://reviews.llvm.org/rG1e6303e60ca5af4fbe7ca728572fd65666a98271>) removed the separate opaque pointer
handling code in `Type::getPointerTo`. Thus, getting rid of
`Type::getPointerTo` seems no longer unnecessary.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152173

Files:
  llvm/include/llvm/IR/Type.h


Index: llvm/include/llvm/IR/Type.h
===================================================================
--- llvm/include/llvm/IR/Type.h
+++ llvm/include/llvm/IR/Type.h
@@ -514,7 +514,6 @@
 
   /// Return a pointer to the current type. This is equivalent to
   /// PointerType::get(Foo, AddrSpace).
-  /// TODO: Remove this after opaque pointer transition is complete.
   PointerType *getPointerTo(unsigned AddrSpace = 0) const;
 
 private:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152173.528466.patch
Type: text/x-patch
Size: 439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230605/4febdc5e/attachment.bin>


More information about the llvm-commits mailing list