[PATCH] D150609: [AMDGPU] Do not assume stack size for PAL code object indirect calls

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 08:43:51 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/resource-usage-pal.ll:5
+; CHECK: scratch_memory_size: 0
+define amdgpu_vs void @test() {
+.entry:
----------------
bsaleil wrote:
> arsenm wrote:
> > Doesn't check a dynamic-is-present metadata field?
> We don't have such flag in PAL abi.
Then that is a problem? You would need one to know you need to add some extra?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150609/new/

https://reviews.llvm.org/D150609



More information about the llvm-commits mailing list