[PATCH] D151035: [OpenMP][OpenMPIRBuilder] Migrate kernel launch code and host fallback code generation from Clang to the OpenMPIRBuilder

Jan Sjödin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 07:55:28 PDT 2023


jsjodin added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:863-898
+static void EmitBranch(IRBuilderBase &Builder, BasicBlock *Target) {
+  // Emit a branch from the current block to the target one if this
+  // was a real block.  If this was just a fall-through block after a
+  // terminator, don't emit it.
+  BasicBlock *CurBB = Builder.GetInsertBlock();
+
+  if (!CurBB || CurBB->getTerminator()) {
----------------
TIFitis wrote:
> D146557 already migrates these along with `emitIfClause`.
Okay, I will rebase this once your patch is merged.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151035/new/

https://reviews.llvm.org/D151035



More information about the llvm-commits mailing list