[PATCH] D150312: [MISched] Introduce and use ResourceSegments.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 07:48:07 PDT 2023


fpetrogalli marked 6 inline comments as done.
fpetrogalli added a comment.

In D150312#4337840 <https://reviews.llvm.org/D150312#4337840>, @RKSimon wrote:

> Also - please add a summary to the patch

Done



================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:864-866
+    static bool sort_predicate(const IntervalTy &A, const IntervalTy &B) {
+      return A.first < B.first;
+    }
----------------
andreadb wrote:
> Can this be an inline lambda used by the std::is_sorted at line 868?
Done, if not for the fact that I have moved the static method in MachineScheduler.cpp because I need it in two places (one of which is an assertion).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150312/new/

https://reviews.llvm.org/D150312



More information about the llvm-commits mailing list