[PATCH] D151986: UniformityAnalysis: Skip computation with no branch divergence

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 05:39:33 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineUniformityAnalysis.cpp:223
   auto &CI = getAnalysis<MachineCycleInfoWrapperPass>().getCycleInfo();
-  UI = computeMachineUniformityInfo(MF, CI, DomTree);
+  // FIXME: Query TTI::hasBranchDivergence. -run-pass seems to end up with a
+  // default NoTTI
----------------
yassingh wrote:
> Can this issue be related to the compiler's inability to construct a Target object when the target is specified using "-march"? This was causing UA to produce incorrect results. https://godbolt.org/z/hqeGovefe
I think this is more of a pass manager issue with -run-pass. It's probably not dealing with IR pass dependencies 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151986/new/

https://reviews.llvm.org/D151986



More information about the llvm-commits mailing list