[PATCH] D152067: [ConstraintElimination] Handle equality predicates

Antonio Frighetto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 04:05:02 PDT 2023


antoniofrighetto added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:950
 
-  bool Changed = false;
-  if (CSToUse.isConditionImplied(R.Coefficients)) {
+  auto ReplaceCmpWithConstant = [&](CmpInst *Cmp, bool IsTrue) {
     if (!DebugCounter::shouldExecute(EliminatedCounter))
----------------
fhahn wrote:
> The changes here are mostly to avoid having to duplicate the code to create True/false constants, and indepdent of the patch, right? Could you split them of into a separate NFC patch?
(Opened a separate patch for it, [[ https://reviews.llvm.org/D152143 | D152143 ]])


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152067/new/

https://reviews.llvm.org/D152067



More information about the llvm-commits mailing list