[PATCH] D143463: [X86] Use the CFA when appropriate for better variable locations around calls.

[Kyle Huey via Phabricator via llvm-commits]

khuey updated this revision to Diff 524120.
khuey retitled this revision from "[X86] Use the CFA as the DWARF frame base for better variable locations around calls." to "[X86] Use the CFA when appropriate for better variable locations around calls.".
khuey edited the summary of this revision.
khuey added a comment.

Revert back to the heuristic based approach for using the CFA only when it affects correctness.

I've realized that it's not *just* the `frame diagnose` tests that fail, 
TestStdFunctionStepIntoCallable.py is also failing. Since not all of lldb's features can cope
with CFA-based DW_AT_frame_bases, let's go back to using the CFA only when the locations are
currently wrong. Then we won't be breaking anything that currently works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143463/new/

https://reviews.llvm.org/D143463

Files:
  llvm/include/llvm/CodeGen/TargetFrameLowering.h
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/CFIInstrInserter.cpp
  llvm/lib/Target/X86/X86FrameLowering.cpp
  llvm/lib/Target/X86/X86FrameLowering.h
  llvm/lib/Target/X86/X86MCInstLower.cpp
  llvm/lib/Target/X86/X86MachineFunctionInfo.h
  llvm/test/DebugInfo/X86/stack_adjustments_trigger_cfa_frame_base.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143463.524120.patch
Type: text/x-patch
Size: 19528 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230521/30a22bae/attachment.bin>